[incubator-kie-issues-1259] RestWorkItemHandler logger set to debug #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
reviewed
Jul 10, 2024
...rkitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java
Show resolved
Hide resolved
fjtirado
reviewed
Jul 10, 2024
...rkitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java
Outdated
Show resolved
Hide resolved
|
Link https://github.com/apache/incubator-kie-kogito-runtimes/pull/3559 does not exist |
|
Issue link updated. |
Abhitocode
force-pushed
the
RestWorkItemHandler-Logging-Output
branch
from
68cc372 to
81a23f8
Compare
Abhitocode
force-pushed
the
RestWorkItemHandler-Logging-Output
branch
from
81a23f8 to
9e55020
Compare
martinweiler
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
LGTM @Abhitocode.
I think it is justified to change the log level to DEBUG in the executeWorkItem method, as the messages are logged for the fallback scenario. So if you define a partial URL and the handler works as expected, you don't want these messages to be logged at INFO on each invocation.
@fjtirado thanks for your feedback on this PR!
pefernan
approved these changes
Jul 22, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging output from RestWorkItemHandler generates too many logs which is not helpful. Changed the log level from info to debug.
Closes: apache/incubator-kie-issues#1259